arcanist: add functions which allow copy-pasting of URLS (#8688)

Co-authored-by: Marc Cornellà <marc.cornella@live.com>

plugins/arcanist/README.md

@@ -11,13 +11,14 @@ plugins=(... arcanist)
 ## Aliases
 
 | Alias   | Command                            |
-|---------|------------------------------------|
+| ------- | ---------------------------------- |
 | ara     | `arc amend`                        |
 | arb     | `arc branch`                       |
 | arco    | `arc cover`                        |
 | arci    | `arc commit`                       |
 | ard     | `arc diff`                         |
 | ardc    | `arc diff --create`                |
+| ardp    | `arc diff --preview`               |
 | ardnu   | `arc diff --nounit`                |
 | ardnupc | `arc diff --nounit --plan-changes` |
 | ardpc   | `arc diff --plan-changes`          |
@@ -27,3 +28,14 @@ plugins=(... arcanist)
 | arli    | `arc lint`                         |
 | arls    | `arc list`                         |
 | arpa    | `arc patch`                        |
+
+## Functions
+
+The following functions make copy pasting revision ids from the URL bar of your browser
+easier, as they allow for copy pasting the whole URL. For example: `ardu` accepts
+both `https://arcanist-url.com/<REVISION>` as well as `<REVISION>`.
+
+| Function                  | Command                           |
+| ------------------------- | --------------------------------- |
+| ardu [URL or revision_id] | `arc diff --update` [revision_id] |
+| arpa [URL or revision_id] | `arc patch` [revision_id]         |

plugins/arcanist/arcanist.plugin.zsh

@@ -13,10 +13,25 @@ alias ardc='arc diff --create'
 alias ardnu='arc diff --nounit'
 alias ardnupc='arc diff --nounit --plan-changes'
 alias ardpc='arc diff --plan-changes'
+alias ardp='arc diff --preview' # creates a new diff in the phab interface
 
 alias are='arc export'
 alias arh='arc help'
 alias arl='arc land'
 alias arli='arc lint'
 alias arls='arc list'
-alias arpa='arc patch'
+
+#
+# Functions
+# (sorted alphabetically)
+#
+
+ardu() {
+  # Both `ardu https://arcanist-url.com/<REVISION>`, and `ardu <REVISION>` work.
+  arc diff --update "${1:t}"
+}
+
+arpa() {
+  # Both `arpa https://arcanist-url.com/<REVISION>`, and `arpa <REVISION>` work.
+  arc patch "${1:t}"
+}

plugins/knife/_knife

@@ -106,10 +106,10 @@ _knife() {
       compadd -Q "$@" show edit list "from file" create delete
       ;;
     bootstrap|clean|cook|prepare)
-      compadd "$@" nodes/*.json(N:t:r); done
+      compadd "$@" nodes/*.json(N:t:r)
       ;;
     init)
-      compadd "$@" ./*(/N:t); done
+      compadd "$@" ./*(/N:t)
       ;;
     *)
       _arguments '3:Subsubcommands:($(_knife_options2))'

plugins/rbenv/rbenv.plugin.zsh

@@ -47,11 +47,10 @@ if [[ $FOUND_RBENV -eq 1 ]]; then
     }
 
     function rbenv_prompt_info() {
-        if [[ -n $(current_gemset) ]] ; then
+        local ruby=$(current_ruby) gemset=$(current_gemset)
-            echo "$(current_ruby)@$(current_gemset)"
+        echo -n "${ZSH_THEME_RUBY_PROMPT_PREFIX}"
-        else
+        [[ -n "$gemset" ]] && echo -n "${ruby}@${gemset}" || echo -n "${ruby}"
-            echo "$(current_ruby)"
+        echo "${ZSH_THEME_RUBY_PROMPT_SUFFIX}"
-        fi
     }
 else
     alias rubies="ruby -v"
@@ -59,7 +58,11 @@ else
     function current_ruby() { echo "not supported" }
     function current_gemset() { echo "not supported" }
     function gems() { echo "not supported" }
-    function rbenv_prompt_info() { echo "system: $(ruby -v | cut -f-2 -d ' ')" }
+    function rbenv_prompt_info() {
+        echo -n "${ZSH_THEME_RUBY_PROMPT_PREFIX}"
+        echo -n "system: $(ruby -v | cut -f-2 -d ' ')"
+        echo "${ZSH_THEME_RUBY_PROMPT_SUFFIX}"
+    }
 fi
 
 unset FOUND_RBENV rbenvdirs dir