random: remove random theme from possible themes to choose from

...preventing an infinite loop.

plugins/jira/README.md

@@ -23,6 +23,9 @@ jira reported [username]  # queries for issues reported by a user
 jira assigned [username]  # queries for issues assigned to a user
 jira myissues   # queries for you own issues
 jira branch     # opens an existing issue matching the current branch name
+                # The branch name may have prefixes ending in "/": "feature/MP-1234",
+                # and also suffixes starting with "_": "MP-1234_fix_dashboard"
+                # In both these cases, the issue opened will be "MP-1234"
 jira ABC-123    # opens an existing issue
 jira ABC-123 m  # opens an existing issue for adding a comment
 ```

plugins/jira/jira.plugin.zsh

@@ -63,26 +63,34 @@ function jira() {
   else
     # Anything that doesn't match a special action is considered an issue name
     # but `branch` is a special case that will parse the current git branch
+    local issue_arg issue
     if [[ "$action" == "branch" ]]; then
-      local issue_arg=$(git rev-parse --abbrev-ref HEAD)
+      # Get name of the branch
-      local issue="${jira_prefix}${issue_arg}"
+      issue_arg=$(git rev-parse --abbrev-ref HEAD)
+      # Strip prefixes like feature/ or bugfix/
+      issue_arg=${issue_arg##*/}
+      # Strip suffixes starting with _
+      issue_arg=(${(s:_:)issue_arg})
+      issue_arg=${issue_arg[1]}
+      if [[ "$issue_arg" = ${jira_prefix}* ]]; then
+        issue="${issue_arg}"
       else
-      local issue_arg=$action
+        issue="${jira_prefix}${issue_arg}"
-      local issue="${jira_prefix}${issue_arg}"
       fi
-    local url_fragment=''
+    else
+      issue_arg=${(U)action}
+      issue="${jira_prefix}${issue_arg}"
+    fi
+
+    local url_fragment
     if [[ "$2" == "m" ]]; then
       url_fragment="#add-comment"
       echo "Add comment to issue #$issue"
     else
       echo "Opening issue #$issue"
     fi
-    if [[ "$JIRA_RAPID_BOARD" == "true" ]]; then
-      open_command "${jira_url}/issues/${issue}${url_fragment}"
-    else
     open_command "${jira_url}/browse/${issue}${url_fragment}"
   fi
-  fi
 }
 
 function _jira_url_help() {

plugins/sdk/sdk.plugin.zsh

@@ -51,12 +51,13 @@ _listInstalledVersions() {
 }
 
 _listInstallableVersions() {
-  __sdkman_list_versions $1 | grep "^ " | sed -e "s/\* /*/g" | \
+  # Remove local (+) and installed (*) versions from the list
-      sed -e "s/>//g" | xargs -n 1 echo | grep -v "^*"
+  __sdkman_list_versions $1 | sed -e '/^[^ ]/d;s/[+*] [^ ]\+//g;s/>//g'
 }
 
 _listAllVersion() {
-  __sdkman_list_versions $1 | grep "^ " | sed -e "s/\*/ /g" | sed -e "s/>//g"
+  # Remove (*), (+), and (>) characters from the list
+  __sdkman_list_versions $1 | sed -e '/^[^ ]/d;s/[*+>] //g'
 }
 
 _sdk () {

themes/random.zsh-theme

@@ -3,7 +3,7 @@ typeset -Ua themes
 
 if [[ "${(t)ZSH_THEME_RANDOM_CANDIDATES}" = array && ${#ZSH_THEME_RANDOM_CANDIDATES[@]} -gt 0 ]]; then
   # Use ZSH_THEME_RANDOM_CANDIDATES if properly defined
-  themes=($ZSH_THEME_RANDOM_CANDIDATES)
+  themes=(${(@)ZSH_THEME_RANDOM_CANDIDATES:#random})
 else
   # Look for themes in $ZSH_CUSTOM and $ZSH and add only the theme name
   themes=(
@@ -12,7 +12,7 @@ else
     "$ZSH"/themes/*.zsh-theme(N:t:r)
   )
   # Remove blacklisted themes from the list
-  for theme in ${ZSH_THEME_RANDOM_BLACKLIST[@]}; do
+  for theme in random ${ZSH_THEME_RANDOM_BLACKLIST[@]}; do
     themes=("${(@)themes:#$theme}")
   done
 fi